From 99b570f0bd774f62e2fb0a97e99030de84364d09 Mon Sep 17 00:00:00 2001 From: gabriel20xx Date: Tue, 11 Nov 2025 20:54:49 +0100 Subject: [PATCH] Revert "feat: enhance navigation behavior in MainApp and add log export functionality in LogsScreen" This reverts commit 29540cad8f0a028f901b240d4c25f6555589f7c7. --- .../collabtable/app/ui/navigation/MainApp.kt | 28 ++++++------------- .../collabtable/app/ui/screens/LogsScreen.kt | 19 +------------ 2 files changed, 10 insertions(+), 37 deletions(-) diff --git a/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/navigation/MainApp.kt b/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/navigation/MainApp.kt index e868311..6752de2 100644 --- a/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/navigation/MainApp.kt +++ b/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/navigation/MainApp.kt @@ -73,32 +73,22 @@ fun MainApp() { NavigationBarItem( selected = currentRoute == Routes.Tables || currentRoute?.startsWith("list/") == true, onClick = { - if (currentRoute?.startsWith("list/") == true) { - // Behave like back from details to tables overview - navController.popBackStack() - } else { - navController.navigate(Routes.Tables) { - popUpTo(navController.graph.findStartDestination().id) { saveState = true } - launchSingleTop = true - restoreState = true - } + navController.navigate(Routes.Tables) { + popUpTo(navController.graph.findStartDestination().id) { saveState = true } + launchSingleTop = true + restoreState = true } }, icon = { androidx.compose.material3.Icon(Icons.Default.Home, contentDescription = null) }, label = { Text("Tables") }, ) NavigationBarItem( - selected = currentRoute == Routes.Settings || currentRoute == Routes.Logs, + selected = currentRoute == Routes.Settings, onClick = { - if (currentRoute == Routes.Logs) { - // Behave like back from logs to settings screen - navController.popBackStack() - } else { - navController.navigate(Routes.Settings) { - popUpTo(navController.graph.findStartDestination().id) { saveState = true } - launchSingleTop = true - restoreState = true - } + navController.navigate(Routes.Settings) { + popUpTo(navController.graph.findStartDestination().id) { saveState = true } + launchSingleTop = true + restoreState = true } }, icon = { androidx.compose.material3.Icon(Icons.Default.Settings, contentDescription = null) }, diff --git a/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/screens/LogsScreen.kt b/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/screens/LogsScreen.kt index 75b3235..5793e73 100644 --- a/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/screens/LogsScreen.kt +++ b/CollabTableAndroid/app/src/main/java/com/collabtable/app/ui/screens/LogsScreen.kt @@ -20,7 +20,6 @@ import androidx.compose.material.icons.Icons import androidx.compose.material.icons.automirrored.filled.ArrowBack import androidx.compose.material3.HorizontalDivider import androidx.compose.material.icons.filled.Delete -import androidx.compose.material.icons.filled.Share import androidx.compose.material.icons.filled.FilterList import androidx.compose.material3.Badge import androidx.compose.material3.Button @@ -55,8 +54,6 @@ import androidx.compose.ui.unit.sp import com.collabtable.app.utils.LogEntry import com.collabtable.app.utils.LogLevel import com.collabtable.app.utils.Logger -import android.content.Intent -import androidx.compose.ui.platform.LocalContext enum class TimeRange(val label: String, val milliseconds: Long) { LAST_10_SECONDS("Last 10 seconds", 10_000), @@ -129,20 +126,6 @@ fun LogsScreen(onNavigateBack: () -> Unit) { } }, actions = { - // Export logs via share intent - val ctx = LocalContext.current - IconButton(onClick = { - val all = logs.joinToString(separator = "\n") { it.toFormattedString() } - val sendIntent = Intent(Intent.ACTION_SEND).apply { - type = "text/plain" - putExtra(Intent.EXTRA_TEXT, all) - putExtra(Intent.EXTRA_SUBJECT, "CollabTable Logs") - } - val chooser = Intent.createChooser(sendIntent, "Export logs") - ctx.startActivity(chooser) - }) { - Icon(Icons.Default.Share, contentDescription = "Export logs") - } IconButton(onClick = { showFilterSheet = true }) { Badge( containerColor = @@ -261,7 +244,7 @@ fun LogsScreen(onNavigateBack: () -> Unit) { modifier = Modifier .fillMaxSize() - .background(MaterialTheme.colorScheme.background), + .background(Color(0xFF1E1E1E)), contentPadding = PaddingValues(8.dp), ) { items(filteredLogs) { log ->